Conversation
incrypto32
approved these changes
May 15, 2025
Member
incrypto32
left a comment
incrypto32
left a comment
There was a problem hiding this comment.
LGTM! apart from the accidental rename of can_filter_by_relationship_fields
|
|
||
| #[test] | ||
| fn can_filter_by_relationship_fields() { | ||
| fn c_by_relationship_fields() { |
Collaborator
Author
There was a problem hiding this comment.
Woops .. yes, nice catch
Comment on lines
+3079
to
+3081
| /// Check that if we have entities where a related entity is null, followed | ||
| /// by one where it is not null that the children are joined correctly to | ||
| /// their respective parent |
Member
There was a problem hiding this comment.
Curios, why a null would cause an issue, Was there a bug that recently got fixed?
Collaborator
Author
There was a problem hiding this comment.
tbh, I don't remember why I wrote that test, and it passed for me on master on the first try. I just figured it doesn't hurt to have this test either way
Check the situation where an entity that has empty relations to other entities is followed by one that does have them and ensure that we link up the children correctly in that situation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the situation where an entity that has empty relations to other entities is followed by one that does have them and ensure that we link up the children correctly in that situation.
Found this change cleaning up old branches, but don't remember what prompted writing it. But another test won't hurt either way